> On Aug. 11, 2015, 9:06 p.m., Jiang Yan Xu wrote:
> > src/slave/containerizer/isolators/filesystem/linux.cpp, lines 318-335
> > <https://reviews.apache.org/r/37236/diff/2/?file=1036681#file1036681line318>
> >
> >     So this is the case where the target is expected to be within the work 
> > dir because a relative path is used. However the user could use something 
> > like
> >     `../a/b/c` to still end up being outside the work dir. Checking it with 
> > `os::realpath()` seems safer.

Added a TODO.


> On Aug. 11, 2015, 9:06 p.m., Jiang Yan Xu wrote:
> > src/slave/containerizer/isolators/filesystem/linux.cpp, lines 312-314
> > <https://reviews.apache.org/r/37236/diff/2/?file=1036681#file1036681line312>
> >
> >     Are these constraints documented somewhere else that the users could 
> > more easily see? mesos.proto seems the reasonable place (aside from a user 
> > doc, of course) but I didn't find it there.
> 
> Timothy Chen wrote:
>     We definitely need a user doc for users to understand how to use the 
> filesystem isolator +1

User doc is out of the scope of this patch. Could you please create a ticket 
for the user doc. Let's do that once this feature is ready to be released.

The isolator interfaces are being documented in 
include/mesos/slave/isolator.hpp.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37236/#review94832
-----------------------------------------------------------


On Aug. 10, 2015, 10:13 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37236/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 10:13 p.m.)
> 
> 
> Review request for mesos, Lily Chen, Ian Downes, Jojy Varghese, Timothy Chen, 
> Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-2794
>     https://issues.apache.org/jira/browse/MESOS-2794
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the linux filesystem isolator.
> 
> Note that the persistent volume part (i.e., update) hasn't been implemented 
> yet.
> 
> This review is derived from https://reviews.apache.org/r/36429/
> 
> Tests are in the subsequent review.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 942003149b071a322933e2c085d9122903f69713 
>   src/slave/containerizer/isolators/filesystem/linux.hpp PRE-CREATION 
>   src/slave/containerizer/isolators/filesystem/linux.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 2cbb879888baf6aff76fbd7c1e19027300fb86e3 
> 
> Diff: https://reviews.apache.org/r/37236/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to