> On Aug. 12, 2015, 6:16 p.m., Jiang Yan Xu wrote: > > src/tests/containerizer/provisioner.hpp, line 34 > > <https://reviews.apache.org/r/37237/diff/3/?file=1035029#file1035029line34> > > > > Should this be called MockProvisioner? I think we use TestXYZ to 'XYZ > > that faciliates tests' and MockXYZ for 'Fake XYZ implemented by GMock'. > > e.g., MockSlave.
We use MockXX if it's a pure mock. In this case, the test provisioner has real behavior (takes a rootfs and return that by default). > On Aug. 12, 2015, 6:16 p.m., Jiang Yan Xu wrote: > > src/tests/containerizer/provisioner.hpp, lines 46-47 > > <https://reviews.apache.org/r/37237/diff/3/?file=1035029#file1035029line46> > > > > Does this not cause the issue mpark > > [mentioned](http://mail-archives.apache.org/mod_mbox/mesos-dev/201507.mbox/%3ccal3vcqqrcwbblf3u2fdhu1myohqgqjub9ul3zjn+oqxx0on...@mail.gmail.com%3E)? > > > > May have to put them in tests themselves. No, it won't. This is from gmock (not gtest). We follow this pattern in many of our test harnesses (e.g., TestLauncher). - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37237/#review95025 ----------------------------------------------------------- On Aug. 8, 2015, 12:32 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37237/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2015, 12:32 a.m.) > > > Review request for mesos, Lily Chen, Ian Downes, Jojy Varghese, Timothy Chen, > Vinod Kone, and Jiang Yan Xu. > > > Bugs: MESOS-2794 > https://issues.apache.org/jira/browse/MESOS-2794 > > > Repository: mesos > > > Description > ------- > > Added a few MesosContainerizer filesystem tests to test the linux filesystem > isolator. > > This adds the tests for https://reviews.apache.org/r/37236/ > > > Diffs > ----- > > src/Makefile.am c213ac779e7acc3235312ca9524b3959417b8c33 > src/tests/containerizer/filesystem_isolator_tests.cpp PRE-CREATION > src/tests/containerizer/provisioner.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/37237/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
