> On Aug. 12, 2015, 10:47 p.m., Jiang Yan Xu wrote:
> > src/slave/containerizer/isolators/filesystem/linux.cpp, line 485
> > <https://reviews.apache.org/r/37330/diff/2/?file=1037046#file1037046line485>
> >
> >     s/other/another/

'other' sounds fine to me here.


> On Aug. 12, 2015, 10:47 p.m., Jiang Yan Xu wrote:
> > src/slave/containerizer/isolators/filesystem/linux.cpp, line 579
> > <https://reviews.apache.org/r/37330/diff/2/?file=1037046#file1037046line579>
> >
> >     What happens when persistent volumes are used without a new rootfs?

Nice catch! That's a bug. I haven't tested the cases where a container does not 
have a new rootfs. I'll follow up with a test.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37330/#review95154
-----------------------------------------------------------


On Aug. 11, 2015, 1:57 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37330/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2015, 1:57 a.m.)
> 
> 
> Review request for mesos, Lily Chen, Ian Downes, Jojy Varghese, Timothy Chen, 
> Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-2794
>     https://issues.apache.org/jira/browse/MESOS-2794
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added persistent volume support for linux filesystem isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/filesystem/linux.hpp PRE-CREATION 
>   src/slave/containerizer/isolators/filesystem/linux.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37330/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> Will follow up with more tests specificially for persistent volumes.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to