> On Aug. 11, 2015, 6:01 p.m., Ben Mahler wrote:
> > src/master/master.hpp, line 1288
> > <https://reviews.apache.org/r/37277/diff/1/?file=1035712#file1035712line1288>
> >
> >     &?

oops. fixed.


> On Aug. 11, 2015, 6:01 p.m., Ben Mahler wrote:
> > src/master/master.hpp, line 1290
> > <https://reviews.apache.org/r/37277/diff/1/?file=1035712#file1035712line1290>
> >
> >     Why is this an Option? Seems like it is required for this.

made it required per discussion.


> On Aug. 11, 2015, 6:01 p.m., Ben Mahler wrote:
> > src/master/master.hpp, line 1302
> > <https://reviews.apache.org/r/37277/diff/1/?file=1035712#file1035712line1302>
> >
> >     Might want to add the 'override' keyword now that we have C++11, the 
> > compiler will make sure that we're actually overriding :)

done.


> On Aug. 11, 2015, 6:01 p.m., Ben Mahler wrote:
> > src/master/master.hpp, line 1630
> > <https://reviews.apache.org/r/37277/diff/1/?file=1035712#file1035712line1630>
> >
> >     Response header or SUBSCRIBED?

i realized the discussion on the proto review now. Yes we added a field to 
SUBSCRIBED for this. fixed.


> On Aug. 11, 2015, 6:01 p.m., Ben Mahler wrote:
> > src/master/master.hpp, lines 1715-1716
> > <https://reviews.apache.org/r/37277/diff/1/?file=1035712#file1035712line1715>
> >
> >     Any reason to avoid Owned?

fixed.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37277/#review94843
-----------------------------------------------------------


On Aug. 9, 2015, 8:31 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37277/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2015, 8:31 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Ben Mahler.
> 
> 
> Bugs: MESOS-3131
>     https://issues.apache.org/jira/browse/MESOS-3131
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Just wanted to send out the abstraction for feedback.
> 
> 
> Diffs
> -----
> 
>   src/internal/evolve.hpp 2e0355960c8c771f28f3ed4428cc047e5787fff7 
>   src/internal/evolve.cpp 4678d67c8324e5c15188b5454e7cc6165d22d9bc 
>   src/master/master.hpp 28356e4ca24312b8be0138a34805b3d9035a99a3 
> 
> Diff: https://reviews.apache.org/r/37277/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> No new tests have been added yet.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Reply via email to