-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37416/#review95235
-----------------------------------------------------------



src/linux/perf.cpp (line 411)
<https://reviews.apache.org/r/37416/#comment150084>

    s/PerfVersion/Perf::version/



src/linux/perf.cpp (line 510)
<https://reviews.apache.org/r/37416/#comment150080>

    These comments need to update too?



src/linux/perf.cpp (line 513)
<https://reviews.apache.org/r/37416/#comment150081>

    reasonable



src/linux/perf.cpp (line 514)
<https://reviews.apache.org/r/37416/#comment150082>

    unavailable



src/linux/perf.cpp (line 516)
<https://reviews.apache.org/r/37416/#comment150083>

    !isReady() contains isFailed(), right?


- Cong Wang


On Aug. 13, 2015, 12:53 a.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37416/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2015, 12:53 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Perf supported() should be based on the version of perf, not the version of 
> the kernel.
> 
> 
> Diffs
> -----
> 
>   src/linux/perf.cpp cb1a13d0b1754a50f0121bfda522056ff8c3e3c8 
> 
> Diff: https://reviews.apache.org/r/37416/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>

Reply via email to