----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37415/#review95299 -----------------------------------------------------------
Patch looks great! Reviews applied: [37414, 37415] All tests passed. - Mesos ReviewBot On Aug. 13, 2015, 4:49 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37415/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2015, 4:49 p.m.) > > > Review request for mesos, Joris Van Remoortere, Joseph Wu, and Till Toenshoff. > > > Bugs: MESOS-830 > https://issues.apache.org/jira/browse/MESOS-830 > > > Repository: mesos > > > Description > ------- > > Fix flaky ExamplesTest.JavaFramework > > > Diffs > ----- > > src/examples/java/TestFramework.java > 265005b9d1a6a053b812c133a4817c3d9e61179e > > Diff: https://reviews.apache.org/r/37415/diff/ > > > Testing > ------- > > This test may fail only infrequently, and the bug is made worse by verbose > logging, so to verify correctness (or reproduce the bug before patching) try: > > GLOG_v=2 GTEST_FILTER="ExamplesTest.JavaFramework" bin/mesos-tests.sh > --verbose --gtest_repeat=100 2>/dev/null | grep "\[" > > > Thanks, > > Greg Mann > >
