-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37382/#review95455
-----------------------------------------------------------



src/slave/containerizer/provisioners/backend.hpp (line 49)
<https://reviews.apache.org/r/37382/#comment150400>

    s/roots/layers/ ?



src/slave/containerizer/provisioners/backend.hpp (line 50)
<https://reviews.apache.org/r/37382/#comment150401>

    How about s/directory/rootfs/ to make it more clear that 'directory' is the 
path to the rootfs?



src/slave/containerizer/provisioners/backend.hpp (lines 55 - 57)
<https://reviews.apache.org/r/37382/#comment150402>

    Hum, what do yo mean here?
    
    I think the backend should be container aware. I.e., we should pass in 
containerid in 'provision'  and destroy will take a containerid as well.
    
    There could be multiple rootfs for a container (because image in volumes). 
When the container finishes, the provisioner will try to destroy all rootfs 
provisioned for that container.
    
    Thoughts?


- Jie Yu


On Aug. 14, 2015, 5:51 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37382/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2015, 5:51 p.m.)
> 
> 
> Review request for mesos, Lily Chen, Ian Downes, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2968
>     https://issues.apache.org/jira/browse/MESOS-2968
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The Backend interface is made generic so it can be used by different 
> provisioners. See 
> [MESOS-2968](https://issues.apache.org/jira/browse/MESOS-2968?focusedCommentId=14652859&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14652859)
>  for details.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am b5dbdc316cad179cd265bd81900999fab35940b9 
>   src/slave/containerizer/provisioners/backend.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/backend.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37382/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Reply via email to