-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37497/#review95509
-----------------------------------------------------------



src/Makefile.am (line 635)
<https://reviews.apache.org/r/37497/#comment150535>

    Does this belong in this review?



src/slave/containerizer/provisioners/docker/local_store.cpp (line 358)
<https://reviews.apache.org/r/37497/#comment150536>

    We align the arrows like what you did in vlog



src/slave/containerizer/provisioners/docker/reference_store.cpp (line 180)
<https://reviews.apache.org/r/37497/#comment150537>

    I think this should be 4 space indented:
    
    if (!os::exists(
            paths.....


- Timothy Chen


On Aug. 15, 2015, 6:56 a.m., Lily Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37497/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2015, 6:56 a.m.)
> 
> 
> Review request for mesos, Jojy Varghese and Timothy Chen.
> 
> 
> Bugs: MESOS-2849
>     https://issues.apache.org/jira/browse/MESOS-2849
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added Docker provisioner paths which handles path manipulation.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 
>   src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/reference_store.cpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37497/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> ./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 
> --gtest_shuffle=1
> 
> 
> Thanks,
> 
> Lily Chen
> 
>

Reply via email to