----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37505/#review95541 -----------------------------------------------------------
Patch looks great! Reviews applied: [37505] All tests passed. - Mesos ReviewBot On Aug. 16, 2015, 9:12 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37505/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2015, 9:12 a.m.) > > > Review request for mesos, Adam B and Timothy Chen. > > > Bugs: MESOS-3136 > https://issues.apache.org/jira/browse/MESOS-3136 > > > Repository: mesos > > > Description > ------- > > Fix broken health check in docker executor. > > > Diffs > ----- > > src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 > src/launcher/executor.cpp 9fa7dcfc39a6706f545b3328e468d9cd25d603ae > src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea > > Diff: https://reviews.apache.org/r/37505/diff/ > > > Testing > ------- > > # Add a new test, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask > sudo ./bin/mesos-tests.sh > --gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthyTask" --verbose > > > Thanks, > > haosdent huang > >