> On Aug. 16, 2015, 3:42 a.m., Timothy Chen wrote: > > configure.ac, line 561 > > <https://reviews.apache.org/r/37493/diff/1/?file=1040648#file1040648line561> > > > > I think we can basically follow the same syntax we've calling > > AC_CHECK_LIB in the other places > > > > [AC_CHECK_LIB([leveldb], > > [leveldb_open], > > [found_leveldb=yes])]) > > > > > > Otherwise this looks good to me.
+1 - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37493/#review95534 ----------------------------------------------------------- On Aug. 15, 2015, 12:28 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37493/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2015, 12:28 a.m.) > > > Review request for mesos, Joris Van Remoortere, Marco Massenzio, and Till > Toenshoff. > > > Bugs: MESOS-1010 > https://issues.apache.org/jira/browse/MESOS-1010 > > > Repository: mesos > > > Description > ------- > > Detect gflags when present and link when building Python module > > > Diffs > ----- > > configure.ac a478ebd331ff2eed25ced2d86d9e6bda3376e2ab > > Diff: https://reviews.apache.org/r/37493/diff/ > > > Testing > ------- > > Did the following: > > ../configure && make && make check > > For each of these cases: > 1. using bundled glog, with gflags not installed > 2. using bundled glog, with gflags installed > 3. using system glog (built without gflags) via --with-glog=..., with gflags > not installed > 4. using system glog (built without gflags) via --with-glog=..., with gflags > installed > 5. using system glog (built with gflags) via --with-glog=..., with gflags > installed > > Test suite passes in all cases. > > > Thanks, > > Greg Mann > >
