-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37531/#review95625
-----------------------------------------------------------



src/master/master.cpp (line 3218)
<https://reviews.apache.org/r/37531/#comment150737>

    Does this logic still needed? I see that the taskTag logic should already 
covered this?



src/messages/messages.proto (line 65)
<https://reviews.apache.org/r/37531/#comment150736>

    I want some comments here for what is taskTag


- Guangya Liu


On Aug. 17, 2015, 1:28 p.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37531/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2015, 1:28 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3070
>     https://issues.apache.org/jira/browse/MESOS-3070
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESOS-3070 (Master CHECK failure if a framework uses duplicated task id.)
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 
>   include/mesos/type_utils.hpp dafe1df0cb5d0b83ca0579068916fe7fda848f02 
>   src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be 
>   src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
>   src/master/validation.cpp ffb7bf07b8a40d6e14f922eabcf46045462498b5 
>   src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c 
> 
> Diff: https://reviews.apache.org/r/37531/diff/
> 
> 
> Testing
> -------
> 
> Draft code diff, will update UT cases later.
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Reply via email to