> On Aug. 17, 2015, 8:52 p.m., Marco Massenzio wrote: > > src/tests/containerizer/rootfs.hpp, line 108 > > <https://reviews.apache.org/r/37555/diff/1/?file=1042512#file1042512line108> > > > > why the trailing comma?
My bad. Removed. > On Aug. 17, 2015, 8:52 p.m., Marco Massenzio wrote: > > src/tests/containerizer/rootfs.hpp, line 119 > > <https://reviews.apache.org/r/37555/diff/1/?file=1042512#file1042512line119> > > > > this seems very 'ad-hoc'? > > not sure what `rootfs->add()` does, but could we just add `/usr/bin` to > > `directories` above, maybe? > > > > Not a big deal, though. I initially did add /usr/bin to 'directories', but found out that copying the whole '/usr/bin' slows down the tests a lot ('/usr/bin' is huge on my dev host). So I did this change. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37555/#review95633 ----------------------------------------------------------- On Aug. 17, 2015, 8:47 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37555/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2015, 8:47 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-3050 > https://issues.apache.org/jira/browse/MESOS-3050 > > > Repository: mesos > > > Description > ------- > > Included /usr/bin/sh in the test root filesystem. > > > Diffs > ----- > > src/tests/containerizer/rootfs.hpp 55dd4964cfb1ca0e5f7b7616ccc6d5ad2be135d7 > > Diff: https://reviews.apache.org/r/37555/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
