-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37549/#review95648
-----------------------------------------------------------


2 high level comments.

Why did you write a whole new script instead of making the current 
jenkins_build.sh work? This is 90% duplicated code which makes me sad.

Also, we shouldn't really depend on non-ASF hosted code (mesosphere's 
wrapdocker) here. Can that script be committed to this repo?

- Vinod Kone


On Aug. 17, 2015, 8:16 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37549/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2015, 8:16 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add jenkins script to run docker tests.
> 
> 
> Diffs
> -----
> 
>   support/docker_tests_jenkins_build.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37549/diff/
> 
> 
> Testing
> -------
> 
> ./support/docker_jenkins_build_test.sh in ubuntu 14.04
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Reply via email to