----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37556/#review95657 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/base64.hpp (line 94) <https://reviews.apache.org/r/37556/#comment150757> s/,/;/ Can you make this a TODO? I'm assuming it's non-trivial to fix this? 3rdparty/libprocess/3rdparty/stout/include/stout/base64.hpp (line 95) <https://reviews.apache.org/r/37556/#comment150758> s/the// ? - Vinod Kone On Aug. 17, 2015, 10:49 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37556/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2015, 10:49 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-3284 > https://issues.apache.org/jira/browse/MESOS-3284 > > > Repository: mesos > > > Description > ------- > > `base64::decode` should return a Try to capture that invalid characters > cannot be decoded. > > Note that base64:: could use some refactoring for clarity. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/base64.hpp > 110cb49fe0a1306cfa8eeee1ffe7b542f75d69b7 > 3rdparty/libprocess/3rdparty/stout/tests/base64_tests.cpp > ff3d31b0ba748ae3dd346d1b70231cbaabd3189a > > Diff: https://reviews.apache.org/r/37556/diff/ > > > Testing > ------- > > Updated the test, note that this still misses validation of the padding > suffix. > > > Thanks, > > Ben Mahler > >
