----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35234/#review95915 -----------------------------------------------------------
Bad patch! Reviews applied: [33752, 35084] Failed command: ./support/apply-review.sh -n -r 35084 Error: 2015-08-20 05:16:46 URL:https://reviews.apache.org/r/35084/diff/raw/ [17310/17310] -> "35084.patch" [1] error: patch failed: configure.ac:444 error: configure.ac: patch does not apply Failed to apply patch - Mesos ReviewBot On Aug. 19, 2015, 8:09 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35234/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2015, 8:09 p.m.) > > > Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. > Clair. > > > Bugs: MESOS-2537 > https://issues.apache.org/jira/browse/MESOS-2537 > > > Repository: mesos > > > Description > ------- > > Let both --enable-$OPTION and --disable-$OPTION work consistently. > Add bundled package options consistent with Mesos, so that options > passed down from Mesos work correctly. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am > 790bb463e7bab43ad0111010d6db7befd160948e > 3rdparty/libprocess/configure.ac 7c2bcffe5c7be1f7d90e6df470d20a00245bfbff > > Diff: https://reviews.apache.org/r/35234/diff/ > > > Testing > ------- > > Make and make check on CentOS 7 and OS X. There's definitely combinations > that have not been tested! > > Note that this removes some login around using gmock. AFAICT the unbundled > gmock doesn't work in the general case. I have a bunch of crashes where the > build would pick up gtest headers from the system and gmock from libprocess > 3rdparty. My conclusion is that the only safe path is to use the bundled > gmock. There's no real path through the build to use decoupled gmock and > gtest, it seems to be assumed that gmock will provide gtest. > > > Thanks, > > James Peach > >
