> On Aug. 24, 2015, 5:53 p.m., Cong Wang wrote:
> > src/linux/perf.cpp, line 418
> > <https://reviews.apache.org/r/37416/diff/5/?file=1045148#file1045148line418>
> >
> >     This is not expected, right?
> 
> Paul Brett wrote:
>     It would be a rare event but not completly unexpected.  After all, perf 
> can be upgraded while mesos is running.

I meant your s/is/it/ change is not expected...


- Cong


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37416/#review96166
-----------------------------------------------------------


On Aug. 21, 2015, 6:46 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37416/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2015, 6:46 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Perf supported() should be based on the version of perf, not the version of 
> the kernel.
> 
> 
> Diffs
> -----
> 
>   src/linux/perf.cpp cdc5f8314a875ababf2b17a32873775d808e1c78 
> 
> Diff: https://reviews.apache.org/r/37416/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>

Reply via email to