> On Aug. 25, 2015, 12:27 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp, lines 142-172
> > <https://reviews.apache.org/r/37187/diff/5/?file=1037650#file1037650line142>
> >
> >     Given that there's no specified iteration order of a multihashmap, I 
> > don't think this is even something to test for.
> >     
> >     That is, this test doesn't test anything further than the test above it:
> >     
> >     ```
> >     ASSERT_EQ(2u, map.get("foo").size());
> >     ASSERT_TRUE(map.contains("foo", 1024));
> >     ASSERT_TRUE(map.contains("foo", 1025));
> >     ```
> >     
> >     I would say we should just remove it, what do you think?
> 
> Jan Schlicht wrote:
>     IMHO the purpose of this test is to show that the iterator iteratates 
> over all elements of a multihashmap, not that the iterater provides a 
> specific order. But given that that this is not too complicated it's probably 
> safe to remove this test.
> 
> Michael Park wrote:
>     Yeah, let's remove this test.

Hm, how about we actually leave the test but follow the pattern for the 
`ForEach` test to ignore the ordering?


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37187/#review96331
-----------------------------------------------------------


On Aug. 25, 2015, 4:02 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37187/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2015, 4:02 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Michael Park.
> 
> 
> Bugs: MESOS-3217
>     https://issues.apache.org/jira/browse/MESOS-3217
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changed hashmap, hashset to use std::unordered_{set,map} instead of 
> boost::unordered_{set,map}.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 
> 25684a405bfa9c4ab65641568341652a8efaf925 
>   3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp 
> ecab60a21765c58b0732de747509aa6382d31c06 
>   3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 
> 2dd1905a4626a7d7e9f61863c8290ae1cdb9b925 
>   3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp 
> a8573ed67e20b5206afd69bab4f5dc094a7e882f 
>   3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp 
> e8ebe0b2f5e49657ee191a2535e0abdaf8e665ce 
>   3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 
> 3802a29b82da57217dd75c6b1611fd21c91cfc03 
>   3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp 
> b625ffaeb3672f58fbd9558a868f87404e659c53 
> 
> Diff: https://reviews.apache.org/r/37187/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Reply via email to