----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37358/#review96369 -----------------------------------------------------------
Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 5:03 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37358/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2015, 5:03 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, > Joris Van Remoortere, and Vinod Kone. > > > Bugs: MESOS-2067 and MESOS-3069 > https://issues.apache.org/jira/browse/MESOS-2067 > https://issues.apache.org/jira/browse/MESOS-3069 > > > Repository: mesos > > > Description > ------- > > Endpoint: /maintenance.start > > Registry operation = maintenance::StartMaintenance > Sets the list of machines as Deactivated. > > > Diffs > ----- > > src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 > src/master/maintenance.hpp PRE-CREATION > src/master/maintenance.cpp PRE-CREATION > src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc > src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf > src/tests/master_maintenance_tests.cpp PRE-CREATION > src/tests/registrar_tests.cpp 032e644ee19751b4ce5767d46f474d34ec4b9166 > > Diff: https://reviews.apache.org/r/37358/diff/ > > > Testing > ------- > > `make check` > > New Tests: > RegistrarTest.StartMaintenance > Schedules some machines. Deactivates some. > MasterMaintenanceTest.StartMaintenance > Tests some invalid lists. > Schedules some machines. Tests some valid and invalid lists. > > > Thanks, > > Joseph Wu > >
