> On Aug. 24, 2015, 5:20 p.m., Timothy Chen wrote:
> > src/slave/containerizer/provisioners/appc/paths.hpp, line 55
> > <https://reviews.apache.org/r/37722/diff/2/?file=1048535#file1048535line55>
> >
> >     Suggestion: It might make sense to nest one more directory "rootfs" so 
> > you can add metadata about that rootfs besides it, also allow more 
> > flexibility in the long run.

Thanks Tim! I chose to use a parent "rootfses" dir to address this concern. 
This is more inline with current practices: Create a parent dir and use a 
sibling file to store the metadata. e.g.: for 

```
                     |-- <backend> (copy, bind, etc.)
                         |-- rootfses
                             |-- XYZ (the rootfs)
```

The meta file could be 

```
                     |-- <backend> (copy, bind, etc.)
                         |-- rootfses
                             |-- XYZ (the meta file)
```

**(Under the meta dir!)**, but of course we'll sort this out when there is an 
actual use case.


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37722/#review96252
-----------------------------------------------------------


On Aug. 24, 2015, 11:26 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37722/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2015, 11:26 a.m.)
> 
> 
> Review request for mesos, Lily Chen, Chi Zhang, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-3308
>     https://issues.apache.org/jira/browse/MESOS-3308
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> More context in /r/37382/ and MESOS-3308.
> 
> I will add the appc backend + provisioner implementation shortly but would 
> like to seek feedback about this design early.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/provisioners/appc/paths.hpp 
> e35805179e67770c6eff7406668caecabefe4fea 
>   src/slave/containerizer/provisioners/appc/paths.cpp 
> a244d9a40e7143134b7bf883514bfcd04d6a6af5 
>   src/slave/paths.hpp dbb1f68d8a789303b595d9e455e2f6f1f0de5c5b 
>   src/slave/paths.cpp 0741616b656e947cb460dd6ee6a9a4852be001c2 
> 
> Diff: https://reviews.apache.org/r/37722/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Reply via email to