-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37747/#review96444
-----------------------------------------------------------

Ship it!



src/slave/containerizer/provisioners/backend.cpp (line 24)
<https://reviews.apache.org/r/37747/#comment151819>

    Add a blank line above.



src/slave/flags.hpp (line 51)
<https://reviews.apache.org/r/37747/#comment151817>

    See my comments below. It's not used, please remove it.



src/slave/flags.cpp (lines 67 - 71)
<https://reviews.apache.org/r/37747/#comment151816>

    This is no longer used in this patch. Could you please remove it.



src/tests/containerizer/provisioner_backend_tests.cpp (line 63)
<https://reviews.apache.org/r/37747/#comment151825>

    Add one line above.



src/tests/containerizer/provisioner_backend_tests.cpp (line 67)
<https://reviews.apache.org/r/37747/#comment151824>

    Kill one line.



src/tests/containerizer/provisioner_backend_tests.cpp (line 85)
<https://reviews.apache.org/r/37747/#comment151826>

    You can do:
    
    ```
    AWAIT_READY(backends["bind"]->provision(...));
    ```



src/tests/containerizer/provisioner_backend_tests.cpp (line 95)
<https://reviews.apache.org/r/37747/#comment151828>

    backends["bind"]->destroy(...)


- Jie Yu


On Aug. 25, 2015, 10:59 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37747/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2015, 10:59 p.m.)
> 
> 
> Review request for mesos, Lily Chen, Jie Yu, Timothy Chen, and Vinod Kone.
> 
> 
> Bugs: MESOS-3190
>     https://issues.apache.org/jira/browse/MESOS-3190
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced bind-mount based provisioner Backend.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db 
>   src/slave/containerizer/provisioners/backend.hpp 
> 46120e8420cc491a0decbd88301f89d6dfcff120 
>   src/slave/containerizer/provisioners/backend.cpp 
> 6190ce3eeff6ea22142c9eaa5a771ae1b767740c 
>   src/slave/containerizer/provisioners/backends/bind.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/backends/bind.cpp PRE-CREATION 
>   src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 
>   src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 
>   src/tests/containerizer/provisioner_backend_tests.cpp PRE-CREATION 
>   src/tests/utils.hpp f2eed2e6fbc2cc8772c642bba976b25b426784e8 
> 
> Diff: https://reviews.apache.org/r/37747/diff/
> 
> 
> Testing
> -------
> 
> sudo make check. Added one test.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Reply via email to