-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37779/#review96456
-----------------------------------------------------------


We should also mention that Labels are supposed to be "light-weight" so that 
the framework writers don't abuse them. Another point worth mentioning would be 
namespacing of labels to avoid conflicts. Finally, should we add pointers to 
the hook modules documentation so as to make the documentation complete?


docs/app-framework-development-guide.md (line 216)
<https://reviews.apache.org/r/37779/#comment151848>

    s/StatusUpdate/TaskStatus



docs/app-framework-development-guide.md (line 217)
<https://reviews.apache.org/r/37779/#comment151849>

    Can we make it a more explicit? i.e. "module writers use Labels to tag and 
..."



docs/app-framework-development-guide.md (line 218)
<https://reviews.apache.org/r/37779/#comment151850>

    s/key value/key-value



docs/app-framework-development-guide.md (line 219)
<https://reviews.apache.org/r/37779/#comment151851>

    s/decorators/label decorator hooks


- Kapil Arya


On Aug. 25, 2015, 7:49 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37779/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2015, 7:49 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-2413
>     https://issues.apache.org/jira/browse/MESOS-2413
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added labels documentation to the framework development guide.
> 
> 
> Diffs
> -----
> 
>   docs/app-framework-development-guide.md 
> db0181c0b82fded1860ef636747e70d80e3884f2 
> 
> Diff: https://reviews.apache.org/r/37779/diff/
> 
> 
> Testing
> -------
> 
> Rendered in Marked2
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Reply via email to