----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37787/#review96501 -----------------------------------------------------------
Patch looks great! Reviews applied: [37787] All tests passed. - Mesos ReviewBot On Aug. 26, 2015, 5:43 a.m., Artem Harutyunyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37787/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2015, 5:43 a.m.) > > > Review request for Benjamin Hindman, Timothy Chen and Vinod Kone. > > > Bugs: MESOS-3313 > https://issues.apache.org/jira/browse/MESOS-3313 > > > Repository: mesos > > > Description > ------- > > Reworked Jenkins build script. Added test images for ubuntu-14.04-clang-3.6, > ubuntu-12.04-gcc-4.8, centos-6.6-gcc-4.8. > > > Diffs > ----- > > support/docker/centos-6.6-gcc-4.8/Dockerfile PRE-CREATION > support/docker/centos-6.6-gcc-4.8/wandisco-svn.repo PRE-CREATION > support/docker/centos-7.1-gcc-4.8/Dockerfile PRE-CREATION > support/docker/ubuntu-12.04-gcc-4.8/Dockerfile PRE-CREATION > support/docker/ubuntu-14.04-clang-3.6/Dockerfile PRE-CREATION > support/docker/ubuntu-14.04-gcc-4.8/Dockerfile PRE-CREATION > support/jenkins_build_docker.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/37787/diff/ > > > Testing > ------- > > `jenkins-build-docker.sh` is a reworked version of the original > `jenkins-build.sh` that is ran by Jenkins buildbot for building and testing > Mesos distributions. > > Features: > * Runs libevent, SSL and ROOT tests. > * Easily add OS/compiler Docker images for testing Mesos. > * Exclude tests on per-image basis. > * Easily reproduce the test image locally. > * Three new test images (ubuntu-14.04-clang-3.6, ubuntu-12.04-gcc-4.8, > centos-6.6-gcc-4.8). > > How to run > > The following environment variables have to be set for the script to run: > * OS - OS name/version. Currently images are available for ubuntu-14.04, > ubuntu-12.04, centos-7.1, centos-6.6. > * CONFIGURATION - ./configure flags (e.g. '--enable-libevent'). > * COMPILER - Compiler name/version. Currently available images include > gcc-4.8 (default value) on all platforms, clang-3.6 on ubuntu-14.04. > > Examples: > `OS=ubuntu-14.04 CONFIGURATION='--enable-ssl --enable-libevent' > COMPILER=clang-3.6 ./jenkins_build_docker.sh` > `OS=centos-7.1 CONFIGURATION='--enable-ssl --enable-libevent' > ./jenkins_build_docker.sh` > > NOTE: Mesos Python module has a known issue on centos-6.6 ( > https://issues.apache.org/jira/browse/MESOS-3314 ), so **for now centos-6.6 > should not be enabled in Jenkins**. > > > Thanks, > > Artem Harutyunyan > >
