----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37791/#review96512 -----------------------------------------------------------
Ship it! LGTM. I could fix the alphabetization when committing. But maybe Yan and Jie want to take a look? src/Makefile.am (lines 1682 - 1685) <https://reviews.apache.org/r/37791/#comment151940> Please alphabetize - Adam B On Aug. 26, 2015, 1:06 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37791/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2015, 1:06 a.m.) > > > Review request for mesos, Adam B and Till Toenshoff. > > > Bugs: MESOS-3316 > https://issues.apache.org/jira/browse/MESOS-3316 > > > Repository: mesos > > > Description > ------- > > The commit 0b6dfac introduced the file `provisioner_backend_test.cpp`. Such > file tests linux only features but was included in the OSX build to which > resulted in compilation errors. This patch addresses that by moving the file > to the `OS_LINUX` section in the `src/Makefile.am` file. Since the file is > only built in linux now, it removes the `ifdef` guards in the file which were > useless to begin with. > > > Diffs > ----- > > src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 > src/tests/containerizer/provisioner_backend_tests.cpp > 096bd4d4bbd602913796c5e542e033bdd9e04964 > > Diff: https://reviews.apache.org/r/37791/diff/ > > > Testing > ------- > > # Both linux and OSX. > make check > > > Thanks, > > Alexander Rojas > >
