-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37495/#review96552
-----------------------------------------------------------


This particular RR review is very much on style only -- would like to invest a 
bit more time in the second round for fully grasping the flow of your tests.


src/Makefile.am (line 1698)
<https://reviews.apache.org/r/37495/#comment152043>

    Alphabetize please.



src/tests/containerizer/docker_provisioner_tests.cpp (line 135)
<https://reviews.apache.org/r/37495/#comment152044>

    Could you please add a one/two-liner above each test that describes its 
purpose?
    
    Imagine an advanced user or developer that tries to run these tests which 
for some reason fail for him - wouldnt it be great if she/he/it immediately 
understood what was being tested without reversing the code?


- Till Toenshoff


On Aug. 25, 2015, 9:01 p.m., Lily Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37495/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2015, 9:01 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, 
> and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-2849
>     https://issues.apache.org/jira/browse/MESOS-2849
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Docker provisioner local store unit tests.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab 
>   src/tests/containerizer/docker_provisioner_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37495/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> ./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 
> --gtest_shuffle=1
> 
> 
> Thanks,
> 
> Lily Chen
> 
>

Reply via email to