-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37738/#review96573
-----------------------------------------------------------

Ship it!



src/tests/containerizer/filesystem_isolator_tests.cpp (line 575)
<https://reviews.apache.org/r/37738/#comment152113>

    A compound statement to test the rootfs pivot as well?
    
    "[ ! -d '" + os::getcwd() + "' ] && [ -d rootfs/bin ]"



src/tests/containerizer/filesystem_isolator_tests.cpp (lines 578 - 579)
<https://reviews.apache.org/r/37738/#comment152116>

    Same as my comment about in the last review about  literals 
"test_image_rootfs" and "test_image_volume" needing to match the ones used to 
create the containerizer. Local variables are more explicit.


- Jiang Yan Xu


On Aug. 24, 2015, 4:22 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37738/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2015, 4:22 p.m.)
> 
> 
> Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a filesystem isolator test to test image in volume while the container 
> root filesystem is also specified.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> 7003b03f1da2fee53592bc23799f59eabcd913a2 
> 
> Diff: https://reviews.apache.org/r/37738/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to