> On June 9, 2015, 12:28 a.m., Cody Maloney wrote: > > configure.ac, line 171 > > <https://reviews.apache.org/r/35084/diff/1/?file=979291#file979291line171> > > > > Since these all follow about the same structure could we add an > > autoconf macro which takes the package name followed by the help > > description and does the rest automatically?
If you send me a JIRA issue, I would prefer to do that as a separate change. This is already larger that I'm really comfortable with. > On June 9, 2015, 12:28 a.m., Cody Maloney wrote: > > configure.ac, line 58 > > <https://reviews.apache.org/r/35084/diff/1/?file=979291#file979291line58> > > > > nit: Could you document auto here? Right now it's an implicit magic > > value like 'bundled' in a lot of ways. > > > > I also wonder if it is possible to have this macro set the AC_ARG_WITH > > / AC_ARG_ENABLE, but that definitely isn't necessary / blocker here. That's documented in rule 4 - "Otherwise use the policy set by --enable-bundled". - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35084/#review86739 ----------------------------------------------------------- On July 15, 2015, 4:59 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35084/ > ----------------------------------------------------------- > > (Updated July 15, 2015, 4:59 a.m.) > > > Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. > Clair. > > > Bugs: MESOS-2537 > https://issues.apache.org/jira/browse/MESOS-2537 > > > Repository: mesos > > > Description > ------- > > Add the MESOS_USE_BUNDLED_PACKAGE() macro to make it easy to provide > consistent behavior for bundled packages selected by either > --enable-bundled-$PACKAGE or --with-$PACKAGE. > > The default policy is set by --enable-bundled and overridden when > the user specifies an --enable-bundled-$PACKAGE or --with-$PACKAGE > option. If --with-$PACKAGE is specified as "bundled", the bundled > version is selected. > > > Diffs > ----- > > configure.ac cad7f0e92eacc86d37b3f578382946db8b466531 > > Diff: https://reviews.apache.org/r/35084/diff/ > > > Testing > ------- > > Configure and build on CentOS 7 and Mac OS X 10.10.3. Verify various (not > exhaustive!) combinations of enabling and disableing bundled packages. > > For example, on CentOS, this alost works: > $ onfigure.developer --disable-bundled --with-zookeeper=bundled > --with-gmock=bundled > > To work completely, this change needs to be propagated to libprocess, which I > can do once reviewers agree that it's the right behavior. > > > Thanks, > > James Peach > >
