> On Aug. 25, 2015, 7:55 p.m., Jiang Yan Xu wrote:
> > src/slave/containerizer/isolators/filesystem/linux.cpp, line 202
> > <https://reviews.apache.org/r/37726/diff/1/?file=1048646#file1048646line202>
> >
> >     Why not just make a copy on the stack?

Chatted offline. We cannot make a copy on the stack because otherwise, we'll 
end up updating the executorInfo on the stack, which will become invalid when 
`_prepare` returns.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37726/#review96403
-----------------------------------------------------------


On Aug. 24, 2015, 7:49 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37726/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2015, 7:49 p.m.)
> 
> 
> Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3310
>     https://issues.apache.org/jira/browse/MESOS-3310
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support for preparing images specified in volumes.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/filesystem/linux.hpp 
> ee5b33d14208770b474e0cb4ab4422381ceb8a3c 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> f36424e94c380870cfde49d55af397fa3dc4a612 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> 7003b03f1da2fee53592bc23799f59eabcd913a2 
> 
> Diff: https://reviews.apache.org/r/37726/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to