> On Aug. 26, 2015, 6:10 p.m., Jiang Yan Xu wrote: > > src/tests/containerizer/filesystem_isolator_tests.cpp, lines 152-158 > > <https://reviews.apache.org/r/37735/diff/1/?file=1048780#file1048780line152> > > > > Rename CREATE_VOLUME to CREATE_VOLUME_FROM_HOST instead? > > > > CREATE_VOLUME only has two usage instances outside this test so it > > should be trivial. > > > > A TODO is fine.
Added a TODO, - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37735/#review96447 ----------------------------------------------------------- On Aug. 24, 2015, 11 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37735/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2015, 11 p.m.) > > > Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > Refactored filesystem isolator tests to allow multiple rootfses. > > > Diffs > ----- > > src/tests/containerizer/filesystem_isolator_tests.cpp > 7003b03f1da2fee53592bc23799f59eabcd913a2 > src/tests/containerizer/provisioner.hpp > c4ba46794fe5d7875fda11155367f521c34ea339 > > Diff: https://reviews.apache.org/r/37735/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
