----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37325/#review96649 -----------------------------------------------------------
Not a full review, mostly nit-picks. Will do a second pass. src/master/http.cpp (line 1366) <https://reviews.apache.org/r/37325/#comment152266> s/./// src/master/maintenance.hpp (lines 26 - 27) <https://reviews.apache.org/r/37325/#comment152262> Please reverse the order and insert a newline. We sort files alphabetically inside the folder, but nested folders go after files. Moreover, these go before stout/* headers. src/master/maintenance.cpp (line 28) <https://reviews.apache.org/r/37325/#comment152271> Libprocess headers go before stout. src/master/maintenance.cpp (line 30) <https://reviews.apache.org/r/37325/#comment152270> Put this right after `<mesos/type_utils.hpp>` please! src/tests/maintenance.hpp (line 50) <https://reviews.apache.org/r/37325/#comment152272> `MachineInfos` is (currently) confusing, since there is a protobuf with such name. - Alexander Rukletsov On Aug. 26, 2015, 9:46 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37325/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2015, 9:46 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, > Joris Van Remoortere, and Vinod Kone. > > > Bugs: MESOS-2067 and MESOS-3069 > https://issues.apache.org/jira/browse/MESOS-2067 > https://issues.apache.org/jira/browse/MESOS-3069 > > > Repository: mesos > > > Description > ------- > > Endpoint: /maintenance.schedule > > Registry operation = maintenance::UpdateSchedule > Replaces the schedule with the given one. Also sets all scheduled machines > into Draining mode. > > Other changes: > Added a note about the "strict" flag. > > > Diffs > ----- > > src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db > src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 > src/master/maintenance.hpp PRE-CREATION > src/master/maintenance.cpp PRE-CREATION > src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc > src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf > src/master/registrar.hpp c6a0655c212646618d93c9c85918af482a9ffd50 > src/tests/maintenance.hpp PRE-CREATION > src/tests/master_maintenance_tests.cpp PRE-CREATION > src/tests/registrar_tests.cpp 032e644ee19751b4ce5767d46f474d34ec4b9166 > > Diff: https://reviews.apache.org/r/37325/diff/ > > > Testing > ------- > > `make check` > > New Tests: > RegistrarTest.UpdateMaintenanceSchedule > Schedules 3 machines, 1 at a time. Rearranges schedules. > Checks that machines are put into Draining mode. Removes machines. > MasterMaintenanceTest.UpdateSchedule > Hits the new endpoint with some valid and invalid schedules. > Only tests a subset of invalid schedules (requires other endpoints to > fully test). > > > Thanks, > > Joseph Wu > >
