----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37821/#review96655 -----------------------------------------------------------
3rdparty/libprocess/src/process.cpp (line 2210) <https://reviews.apache.org/r/37821/#comment152273> Somewhat race-prone: we might see "shutting_down.load() == false", proceed to deliver the inbound message, and yet the shutdown code can proceed concurrently. After a bit of poking I couldn't find a situation in which that would be problematic, but maybe worth exploring if there's a known data race/hang... - Neil Conway On Aug. 27, 2015, 4:28 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37821/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2015, 4:28 a.m.) > > > Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and > switched to 'mcypark'. > > > Bugs: MESOS-3158 > https://issues.apache.org/jira/browse/MESOS-3158 > > > Repository: mesos > > > Description > ------- > > Join threads in libprocess when shutting down. > > > Diffs > ----- > > 3rdparty/libprocess/src/event_loop.hpp > 36a4cd2b1ff59f6922173ad17115bf80cc3c8f30 > 3rdparty/libprocess/src/libev.cpp 97a2694f9b10bc61841443b21f4f96055493e840 > 3rdparty/libprocess/src/libevent.cpp > d7c47fbd1dbdec1fc974840e6f3a1428a8f189d5 > 3rdparty/libprocess/src/process.cpp > 755187c8761137cb2bf2f7295b29a63f63c68bc6 > > Diff: https://reviews.apache.org/r/37821/diff/ > > > Testing > ------- > > After configuring with both "../configure" and "../configure > --enable-libevent --enable-ssl": > > make check > > > Thanks, > > Greg Mann > >
