-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37247/#review96659
-----------------------------------------------------------

Ship it!


Ship It!


src/slave/containerizer/provisioners/docker/reference_store.hpp (line 49)
<https://reviews.apache.org/r/37247/#comment152278>

    Add a TODO somewhere for this.



src/slave/containerizer/provisioners/docker/reference_store.cpp (line 171)
<https://reviews.apache.org/r/37247/#comment152275>

    Check the result and log if something went wrong.



src/slave/containerizer/provisioners/docker/reference_store.cpp (line 193)
<https://reviews.apache.org/r/37247/#comment152277>

    more specific reasons like: Skipped loading image due to missing layers



src/slave/containerizer/provisioners/docker/reference_store.cpp (line 197)
<https://reviews.apache.org/r/37247/#comment152276>

    Loaded instead of Obtained


- Timothy Chen


On Aug. 26, 2015, 5:57 p.m., Lily Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37247/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2015, 5:57 p.m.)
> 
> 
> Review request for mesos, Till Toenshoff and Timothy Chen.
> 
> 
> Bugs: MESOS-3021
>     https://issues.apache.org/jira/browse/MESOS-3021
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added Docker image reference store.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab 
>   src/messages/docker_provisioner.hpp PRE-CREATION 
>   src/messages/docker_provisioner.proto PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/reference_store.hpp 
> PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/reference_store.cpp 
> PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37247/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Tests will be added in a later review.
> 
> 
> Thanks,
> 
> Lily Chen
> 
>

Reply via email to