----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/#review96672 -----------------------------------------------------------
There's an instance of `hash_value` still in `3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp` currently. Turns out `boost::hash_combine(seed, value)` combines the result of `hash_value(value)` into `seed` which makes this work. We'll replace `boost::hash_combine` in a follow-up patch, for now let's change `hash_value` for `net::IP` into `std::hash`. This subsequently requires updating 2 callsites of `boost::hash_combine`, one in `3rdparty/libprocess/include/process/address.hpp` and the other in `3rdparty/libprocess/src/pid.cpp`. 3rdparty/libprocess/src/pid.cpp (line 153) <https://reviews.apache.org/r/37188/#comment152297> This is 81 chars, we could either `s/upid/pid/`, or wrap the argument. I'll leave this up to you. - Michael Park On Aug. 27, 2015, 11:39 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37188/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2015, 11:39 a.m.) > > > Review request for mesos, Alexander Rojas and Michael Park. > > > Bugs: MESOS-3217 > https://issues.apache.org/jira/browse/MESOS-3217 > > > Repository: mesos > > > Description > ------- > > Added std::hash template specializations. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/address.hpp > df78f8e525c40b87e734e16979d3315f89e12594 > 3rdparty/libprocess/include/process/pid.hpp > 8d3735c7d5b8f74a7a0ebb8cafe7c7ebee68f5f0 > 3rdparty/libprocess/src/pid.cpp f5528aea04a17ce868a0f67b94defdefea18e234 > 3rdparty/libprocess/src/tests/http_tests.cpp > c22f9d35b5dc959ce9816d3358ebff92b853bf52 > > Diff: https://reviews.apache.org/r/37188/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >