----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37621/#review96930 -----------------------------------------------------------
Ship it! src/sched/sched.cpp (line 525) <https://reviews.apache.org/r/37621/#comment152622> Let's just simplify this and only call 'resourceOffers' if 'offers.size() != 0'. - Benjamin Hindman On Aug. 26, 2015, 2:13 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37621/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2015, 2:13 a.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. > > > Bugs: MESOS-1474 > https://issues.apache.org/jira/browse/MESOS-1474 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 > src/tests/master_maintenance_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/37621/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >