-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37362/
-----------------------------------------------------------
(Updated Aug. 28, 2015, 4:20 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan,
Joris Van Remoortere, and Vinod Kone.
Changes
-------
Rebased + changes from previous reviews.
Summary (updated)
-----------------
Maintenance Primitives: Adds an endpoint for transitioning agents back into UP
mode.
Bugs: MESOS-2067 and MESOS-3069
https://issues.apache.org/jira/browse/MESOS-2067
https://issues.apache.org/jira/browse/MESOS-3069
Repository: mesos
Description (updated)
-------
Endpoint: /machine/up
Registry operation = maintenance::StopMaintenance
Sets the list of machines back to UP mode. Removes those machines from the
maintenance schedule.
Diffs (updated)
-----
src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44
src/master/maintenance.hpp PRE-CREATION
src/master/maintenance.cpp PRE-CREATION
src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc
src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
src/tests/master_maintenance_tests.cpp PRE-CREATION
src/tests/registrar_tests.cpp 032e644ee19751b4ce5767d46f474d34ec4b9166
Diff: https://reviews.apache.org/r/37362/diff/
Testing (updated)
-------
`make check`
New Tests:
RegistrarTest.StopMaintenance
Schedules some machines. Deactivates some. Reactivates some.
MasterMaintenanceTest.BringUpMachines
Tests some invalid lists.
Schedules some machines. Deactivates some. Tests some valid and invalid
lists.
Checks that the schedule is modified.
Thanks,
Joseph Wu
