-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37364/
-----------------------------------------------------------

(Updated Aug. 28, 2015, 5:04 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
Joris Van Remoortere, and Vinod Kone.


Changes
-------

Rebased and updated to match changes in previous reviews.


Bugs: MESOS-2067
    https://issues.apache.org/jira/browse/MESOS-2067


Repository: mesos


Description (updated)
-------

Endpoint: /maintenance/status

Also adds a protobuf for the purpose of serialization.


Diffs (updated)
-----

  include/mesos/maintenance/maintenance.proto PRE-CREATION 
  src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 
  src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc 
  src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
  src/tests/master_maintenance_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37364/diff/


Testing
-------

`make check`

New Tests:
  MasterMaintenanceTest.FailToUnscheduleDeactivatedMachines
    Extra test case for the /maintenance.schedule endpoint, which requires all 
three endpoints to work.
  MasterMaintenanceTest.MachineStatus
    Schedules, starts, and stops maintenance.  Checks machine statuses after 
each step.


Thanks,

Joseph Wu

Reply via email to