----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37913/#review96976 -----------------------------------------------------------
Patch looks great! Reviews applied: [37913] All tests passed. - Mesos ReviewBot On Aug. 28, 2015, 11:46 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37913/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2015, 11:46 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-3052 > https://issues.apache.org/jira/browse/MESOS-3052 > > > Repository: mesos > > > Description > ------- > > When frameworks refuse a lot of resources, the list of filters gets > long. Since the filters are per-slave, > HierarchicalAllocatorProcess::isFiltered spends a lot of time just > comparing SlaveID (which tend to be long strings). Eliminate this > whole problem by organizing the filters by SlaveID in the first > place. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 38f8fd2c84314bb3731684d0e9795cb4f50a227e > > Diff: https://reviews.apache.org/r/37913/diff/ > > > Testing > ------- > > make check on CentOS 6 w/ devtoolset-3. > > > Thanks, > > James Peach > >
