> On Aug. 28, 2015, 7:32 p.m., Bernd Mathiske wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp, line 59
> > <https://reviews.apache.org/r/37669/diff/4/?file=1047966#file1047966line59>
> >
> >     "allowed" and "would" are not quite right.
> >     
> >     Suggested phrasing:
> >     
> >     << "only " << maxComponents << " components will "
> >     << "be recognized, the rest will be ignored."

Thank you. Let me update.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37669/#review96878
-----------------------------------------------------------


On Aug. 22, 2015, 5:04 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37669/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2015, 5:04 p.m.)
> 
> 
> Review request for mesos, Isabel Jimenez and Timothy Chen.
> 
> 
> Bugs: MESOS-2986
>     https://issues.apache.org/jira/browse/MESOS-2986
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ignore overflow components in version parsing.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 
> 51010845e8885ac52ce88ec0deb6b65a81122cba 
>   3rdparty/libprocess/3rdparty/stout/tests/version_tests.cpp 
> e8f8358f3c113b4e21e30cb5e9d6a3d229191484 
> 
> Diff: https://reviews.apache.org/r/37669/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to