----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37932/#review97025 -----------------------------------------------------------
Patch looks great! Reviews applied: [37932] All tests passed. - Mesos ReviewBot On Aug. 30, 2015, 10:23 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37932/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2015, 10:23 a.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > When launching tasks, if the task is in pending list, mesos master > will remove the task from pending list and run the task. But the > current logic is remove the task from pending list first, then check > authorization, so for such case, if authorization failed, the task > will be lost. > > This patch is moving the logic of removing pending task after some > guard to make sure the pending task will be removed when master is > planning to launch the task. > > > Diffs > ----- > > src/master/master.cpp b824f96e293e3d950d426209c3c8e3b5c9f527b7 > > Diff: https://reviews.apache.org/r/37932/diff/ > > > Testing > ------- > > > Thanks, > > Guangya Liu > >
