----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37177/#review97073 -----------------------------------------------------------
src/master/allocator/mesos/hierarchical.hpp (line 391) <https://reviews.apache.org/r/37177/#comment152804> Indent: Line 392: Need to delete a space. Line 393: Need to add 7 more spaces to align with line 392. src/master/allocator/mesos/hierarchical.hpp (line 1118) <https://reviews.apache.org/r/37177/#comment152807> s/send inverse offer/deallocate resources/ src/master/allocator/mesos/hierarchical.hpp (line 1136) <https://reviews.apache.org/r/37177/#comment152809> So here we only use framework sorters, then why we check role sorter in the beginning of this method? src/master/allocator/mesos/hierarchical.hpp (line 1154) <https://reviews.apache.org/r/37177/#comment152811> Remove "we"? src/master/master.cpp (line 623) <https://reviews.apache.org/r/37177/#comment152803> In future, we may need to add more callback functions, so here can we change to use a general structure to keep the callback functions that we want to pass into allocator? So in future, if we want to add more callback functions, just need to change that structure rather than the signature of allocator->initialize() - Qian Zhang On Aug. 26, 2015, 2:12 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37177/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2015, 2:12 a.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. > > > Bugs: MESOS-1474 > https://issues.apache.org/jira/browse/MESOS-1474 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/maintenance/maintenance.hpp PRE-CREATION > include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a > src/master/allocator/mesos/allocator.hpp > aa55755a9c3250579e9366bdbc17a2449e95d659 > src/master/allocator/mesos/hierarchical.hpp > 38f8fd2c84314bb3731684d0e9795cb4f50a227e > src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc > src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf > src/tests/hierarchical_allocator_tests.cpp > 9748ca0b38888fee25dcec51c64d8ba84dbd4aaf > src/tests/master_allocator_tests.cpp > 89331965553505f6b7eebf39ad27d943df816a24 > src/tests/mesos.hpp 637636ac69dde02da6b7200d7c666cac89b051cb > src/tests/reservation_tests.cpp aeee36752573e3f401d3dca7d2d69c90d0e8bd6b > src/tests/resource_offers_tests.cpp > 882a9ff4d09aace486182828bf43b643b0d0c519 > src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc > > Diff: https://reviews.apache.org/r/37177/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
