> On Aug. 31, 2015, 9:25 p.m., Michael Park wrote:
> > @Guangya: I pointed out the undefined behavior as specified in the C++ 
> > Standard in this review: [r25735](https://reviews.apache.org/r/25735/). 
> > Also, refer to  
> > [MESOS-3246](https://issues.apache.org/jira/browse/MESOS-3246) which I 
> > filed in addition to adding the comment.

P.S. I would be happy to shepherd 
[MESOS-3246](https://issues.apache.org/jira/browse/MESOS-3246) if you would 
like to tackle it.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37945/#review97149
-----------------------------------------------------------


On Aug. 31, 2015, 8:55 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37945/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2015, 8:55 p.m.)
> 
> 
> Review request for mesos, switched to 'mcypark' and Vinod Kone.
> 
> 
> Bugs: MESOS-1805
>     https://issues.apache.org/jira/browse/MESOS-1805
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> change const pass-by-value to const reference in stout
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 
> 1cf6dd18aa163688d6c8f3a6d33eacad3918015d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/shell.hpp 
> 68fc1fd179ee51fc5de0452c0f2ea3d354e0567f 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp 
> 01e59de466496dec9367ad6f48538327f53a7e18 
> 
> Diff: https://reviews.apache.org/r/37945/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Reply via email to