-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37969/#review97202
-----------------------------------------------------------


Patch looks great!

Reviews applied: [37969]

All tests passed.

- Mesos ReviewBot


On Aug. 31, 2015, 9:42 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37969/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2015, 9:42 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaces `__.DebugString()` with `stringify(JSON::Protobuf(__))`, which looks 
> nicer and matches the JSON expected by the HTTP endpoints.
> 
> Addresses a comment found here: 
> https://reviews.apache.org/r/37358/#comment152513
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e 
>   src/master/maintenance.cpp 277dd8270fbd497616e5b24db4ea7dd615e170e3 
> 
> Diff: https://reviews.apache.org/r/37969/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> This change will tweak the output from:
> ```
> Machine 'hostname: "myComputer"
> ' is not valid because ...
> 
> ```
> (`DebugString` ^ puts a newline there.)
> 
> To: 
> ```
> Machine '{"hostname":"myComputer"}' is not valid because ...
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Reply via email to