> On Aug. 27, 2015, 2:22 a.m., haosdent huang wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h, line 38 > > <https://reviews.apache.org/r/37827/diff/1/?file=1055568#file1055568line38> > > > > Need adjust order here? > > Alexander Rukletsov wrote: > Not sure I follow, what exactly do you mean? > > haosdent huang wrote: > Oh, sorry for my english. I mean do we need ajust the order to > ``` > class Message; > class Nested; > class SimpleMessage; > ```
Oh, I see. You are right, we should have adjusted the order if this was "our" file. However, the file is generated by the `protoc`, hence no manual tinkering is expected. I have filed [MESOS-3323](https://issues.apache.org/jira/browse/MESOS-3323) to address the issue in the first place. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37827/#review96629 ----------------------------------------------------------- On Aug. 27, 2015, 3:38 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37827/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2015, 3:38 a.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-3312 > https://issues.apache.org/jira/browse/MESOS-3312 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp > c56d6a3098293eb3659b3066f10e875927ec3ac3 > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h > cfc2803e42284f641879fb24bce1282215c8ea52 > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc > a1d4084661345f9367c75f9db61279f032b93e69 > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto > bbd36d39e9588eb8eea6d739451ad3bab029ca08 > > Diff: https://reviews.apache.org/r/37827/diff/ > > > Testing > ------- > > make check (Mac OS 10.10.4) > > **NOTE**: Filed > [MESOS-3323](https://issues.apache.org/jira/browse/MESOS-3323) to clean up > protobuf generation. > > > Thanks, > > Alexander Rukletsov > >
