> On Sept. 1, 2015, 12:18 a.m., Qian Zhang wrote: > > include/mesos/master/allocator.hpp, line 48 > > <https://reviews.apache.org/r/37958/diff/1/?file=1060349#file1060349line48> > > > > I think we do not want "{}" in the newline.
Fixed. > On Sept. 1, 2015, 12:18 a.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 398 > > <https://reviews.apache.org/r/37958/diff/1/?file=1060351#file1060351line398> > > > > Tab here? If so, we may need to replace tab with spaces. AFAICT these are spaces. > On Sept. 1, 2015, 12:18 a.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 397 > > <https://reviews.apache.org/r/37958/diff/1/?file=1060351#file1060351line397> > > > > Instead of checking allocationOptions.allocateOnEvents everywhere, can > > we just do it once internally in allocate()? The problem with doing it in allocate() is that allocate() doesn't know whether it is being called in response to a cluster event, or by the periodic allocation cycle. We could pass down a flag or wrap it in some other way, but that did not seem any less clumsy. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37958/#review97210 ----------------------------------------------------------- On Aug. 31, 2015, 4:49 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37958/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2015, 4:49 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-3157 > https://issues.apache.org/jira/browse/MESOS-3157 > > > Repository: mesos > > > Description > ------- > > Normally, the mesos-master performs allocation cycles in response > to protocol messages and cluster events. This ties the cost of > allocation to the amount of churn in the environment, which can led > to unpredictable performance. Add an option to disable this, meaning > that allocations are only every performed by the batch interval > task. This makes resource allocation a fixed cost, independent of > the amount of environmental churn. > > > Diffs > ----- > > docs/configuration.md 2b23d48c8841e43e6e2776dfe6bfa7c022a941a7 > include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a > src/master/allocator/mesos/allocator.hpp > aa55755a9c3250579e9366bdbc17a2449e95d659 > src/master/allocator/mesos/hierarchical.hpp > 38f8fd2c84314bb3731684d0e9795cb4f50a227e > src/master/flags.hpp e4b1df3f5a33049defff4688463274067f1f1ebf > src/master/flags.cpp 230c1dcedfbbb410b89defd90159d964c001a615 > src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf > src/tests/hierarchical_allocator_tests.cpp > 9748ca0b38888fee25dcec51c64d8ba84dbd4aaf > src/tests/mesos.hpp b2160f50db3e0b0d04b0625e7589004016c0f746 > > Diff: https://reviews.apache.org/r/37958/diff/ > > > Testing > ------- > > "make check" on CentOS 6 w/ devtoolset-3. Running in production for multiple > weeks. > > > Thanks, > > James Peach > >
