-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37785/#review97353
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Aug. 26, 2015, 3:07 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37785/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2015, 3:07 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-3311
>     https://issues.apache.org/jira/browse/MESOS-3311
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> I was not able to reproduce this with 300 gtest iterations in a loop on a 
> Ubuntu 14.04 VM with clang + ssl i.e. similar to the ASF setup.
> 
> The logs though made it pretty evident on what was going on. The slave was 
> sending a retry re-register message to the master, resulting in the master 
> sending back another FrameworkUpdateMessage, the 2nd one used to set the PID 
> from None() to the original pid() making the message go through directly to 
> the scheduler instead of being routed through the master.
> 
> Log Lines:
> 
> I0825 22:07:39.085610 27642 slave.cpp:1209] Will retry registration in 
> 6.014445ms if necessary
> I0825 22:07:39.092914 27640 master.cpp:3773] Re-registering slave 
> 20150825-220736-234885548-51219-27610-S0 at slave(286)@172.17.0.14:51219 
> (09c6504e3a31)
> I0825 22:07:39.093181 27630 slave.cpp:1209] Will retry registration in 
> 20.588077ms if necessary
> .... some lines and then
> I0825 22:07:39.094435 27640 master.cpp:3773] Re-registering slave 
> 20150825-220736-234885548-51219-27610-S0 at slave(287)@172.17.0.14:51219 
> (09c6504e3a31)
> ... more lines
> I0825 22:07:39.096372 27635 slave.cpp:2131] Updating framework 
> 20150825-220736-234885548-51219-27610-0000 pid to @0.0.0.0:0
> ... more lines
> I0825 22:07:39.097450 27635 slave.cpp:2131] Updating framework 
> 20150825-220736-234885548-51219-27610-0000 pid to 
> scheduler-6c5ddcdb-9dd1-4b38-b051-5f714d3c1c55@172.17.0.14:51219
> ... more lines
> I0825 22:07:39.098433 27635 slave.cpp:3043] Sending message for framework 
> 20150825-220736-234885548-51219-27610-0000 to 
> scheduler-6c5ddcdb-9dd1-4b38-b051-5f714d3c1c55@172.17.0.14:51219
> 
> 
> Paused the clock and then settle/resume invocations to ensure the retry does 
> not happen
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp d55e9dd4f4eb84a8fda85439e31a38e70890b377 
> 
> Diff: https://reviews.apache.org/r/37785/diff/
> 
> 
> Testing
> -------
> 
> make check again with 300 iterations without failure
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Reply via email to