----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37280/#review97428 -----------------------------------------------------------
include/mesos/master/allocator.hpp (line 147) <https://reviews.apache.org/r/37280/#comment153305> I was adding comments for all allocator interface in https://issues.apache.org/jira/browse/MESOS-2224 , and it would be great that all new added interface have comments. src/master/allocator/mesos/hierarchical.hpp (line 885) <https://reviews.apache.org/r/37280/#comment153306> "We shouldn't update an inverse offer if we didn't send one out." may be better? - Guangya Liu On 八月 26, 2015, 2:13 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37280/ > ----------------------------------------------------------- > > (Updated 八月 26, 2015, 2:13 a.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. > > > Bugs: MESOS-1474 > https://issues.apache.org/jira/browse/MESOS-1474 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a > src/master/allocator/mesos/allocator.hpp > aa55755a9c3250579e9366bdbc17a2449e95d659 > src/master/allocator/mesos/hierarchical.hpp > 38f8fd2c84314bb3731684d0e9795cb4f50a227e > src/tests/mesos.hpp 637636ac69dde02da6b7200d7c666cac89b051cb > > Diff: https://reviews.apache.org/r/37280/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
