----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38050/#review97434 -----------------------------------------------------------
src/master/master.cpp <https://reviews.apache.org/r/38050/#comment153311> The indent seems incorrect, here's the suggestion: install<PongSlaveMessage>( &SlaveObserver::pong); src/slave/slave.cpp <https://reviews.apache.org/r/38050/#comment153312> In slave's UT case, here're at least two cases about PING/PONG package: PingTimeoutSomePings & PingTimeoutNoPings; are those UT cases impacted? If so please help to update accordingly; and please also help to check the other UT cases about PING/PONG message, I'd not go through all slave UT cases. - Klaus Ma On Sept. 2, 2015, 12:11 p.m., Yong Qiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38050/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2015, 12:11 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1831 and MESOS-1832 > https://issues.apache.org/jira/browse/MESOS-1831 > https://issues.apache.org/jira/browse/MESOS-1832 > > > Repository: mesos > > > Description > ------- > > Master should send PingSlaveMessage instead of "PING"; Slave should accept > PingSlaveMessage but not "PING" message; > > > Diffs > ----- > > src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 > src/slave/slave.hpp 09172f7ed547049b3bd169b3db9be94e14f6bc39 > src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4 > > Diff: https://reviews.apache.org/r/38050/diff/ > > > Testing > ------- > > > Thanks, > > Yong Qiao Wang > >
