> On Sept. 1, 2015, 11:43 p.m., Ben Mahler wrote: > > src/linux/perf.hpp, line 56 > > <https://reviews.apache.org/r/37462/diff/7/?file=1061618#file1061618line56> > > > > Whoops, doesn't this comment belong on the parse function?
Actually, it applies to both of them. I'll make that clear. - Paul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37462/#review97360 ----------------------------------------------------------- On Sept. 2, 2015, 6:52 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37462/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2015, 6:52 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2834 > https://issues.apache.org/jira/browse/MESOS-2834 > > > Repository: mesos > > > Description > ------- > > Add support for version detection and parsing. > > > Diffs > ----- > > src/linux/perf.hpp c44445630118f4858b1a805f25a2db7a24ca0989 > src/linux/perf.cpp bb8b5918e4c8f4379784d4fa18c3b4709696e1ea > src/tests/containerizer/perf_tests.cpp > 8c29ca3dc2a8f6d1fb0f430482190f87f08eb4e8 > > Diff: https://reviews.apache.org/r/37462/diff/ > > > Testing > ------- > > sudo make check > > Perf tests may fail on many machines because the tests are currently using > the version of perf installed on the machine to choose decode. The next > patch will extend the perf tests to supply test cases for each of the > supported perf versions. > > > Thanks, > > Paul Brett > >
