-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37622/#review97555
-----------------------------------------------------------

Ship it!



src/master/http.cpp (line 1567)
<https://reviews.apache.org/r/37622/#comment153561>

    Now that the endpoint is called `/machine/down`, should the message be set 
to something like:
    "Operator initiated"?  Or "Machine down"?



src/tests/master_maintenance_tests.cpp (lines 631 - 632)
<https://reviews.apache.org/r/37622/#comment153550>

    The first `{` could be moved up a line.


- Joseph Wu


On Sept. 2, 2015, 12:33 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37622/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2015, 12:33 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
>     https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e 
>   src/tests/master_maintenance_tests.cpp 
> fb8dca3757a9565d5eb5a69eed10aa34602bb15c 
> 
> Diff: https://reviews.apache.org/r/37622/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Reply via email to