----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37929/#review97585 -----------------------------------------------------------
Ship it! Ship It! src/slave/containerizer/provisioners/appc/store.cpp (line 235) <https://reviews.apache.org/r/37929/#comment153605> The wording sounds wierd, how about: "Cannot match any image in store for '" + image.name() - Timothy Chen On Sept. 3, 2015, 12:07 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37929/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2015, 12:07 a.m.) > > > Review request for mesos, Chi Zhang, Jie Yu, and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > - i.e., It fetches images transparently when it's not in the local cache. > - This way, the store doesn't have the sense of "localness" anymore but > rather it's an abstraction that provides access to all discoverable images, > no matter where they can be found. > > Some context for motivation of this change can be found at: > https://reviews.apache.org/r/37881/ > > > Diffs > ----- > > src/slave/containerizer/provisioners/appc/store.hpp > e48d91be06410bfc028a7b2ed88218e13adbffee > src/slave/containerizer/provisioners/appc/store.cpp > fbd1c535d398a4d37c30ba23f5408095c7d35b65 > src/tests/containerizer/appc_provisioner_tests.cpp > 47b66b9c30cefe8f9a8e2c1c1341776c2d235020 > > Diff: https://reviews.apache.org/r/37929/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
