> On 九月 2, 2015, 6:14 p.m., Joseph Wu wrote: > > include/mesos/master/allocator.hpp, lines 92-93 > > <https://reviews.apache.org/r/37993/diff/3/?file=1061967#file1061967line92> > > > > These two @param's don't add much, so you could exclude them. > > > > I added comments like this in the past, which led to this email thread: > > http://www.mail-archive.com/dev%40mesos.apache.org/msg32792.html
Done. > On 九月 2, 2015, 6:14 p.m., Joseph Wu wrote: > > include/mesos/master/allocator.hpp, line 111 > > <https://reviews.apache.org/r/37993/diff/3/?file=1061967#file1061967line111> > > > > Again, this doesn't add much. It's up to you if you want to keep it or > > not. > > > > Same for all the similar @param's below (not marked). All rmeoved if too simple > On 九月 2, 2015, 6:14 p.m., Joseph Wu wrote: > > include/mesos/master/allocator.hpp, line 143 > > <https://reviews.apache.org/r/37993/diff/3/?file=1061967#file1061967line143> > > > > Again, try not to document the HierarchicalDRF ("the built-in > > allocator"). > > > > s/revocable/revocable resources/ I want to add some comments for built-in allocator so that the end user can take some reference for this, make snese? Thanks. > On 九月 2, 2015, 6:14 p.m., Joseph Wu wrote: > > include/mesos/master/allocator.hpp, lines 217-218 > > <https://reviews.apache.org/r/37993/diff/3/?file=1061967#file1061967line217> > > > > Suggestion: > > An agent may be deactivated if it is disconnnected from the master. I was using slave here to keep consistent, will upload another patch to rename slave to agent, hope it is OK. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review97478 ----------------------------------------------------------- On 九月 2, 2015, 3:06 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37993/ > ----------------------------------------------------------- > > (Updated 九月 2, 2015, 3:06 a.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, and Michael Park. > > > Bugs: MESOS-2224 > https://issues.apache.org/jira/browse/MESOS-2224 > > > Repository: mesos > > > Description > ------- > > Add explanatory comments for Allocator interface > > > Diffs > ----- > > include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a > > Diff: https://reviews.apache.org/r/37993/diff/ > > > Testing > ------- > > > Thanks, > > Guangya Liu > >
